Skip to content

Fix JS bundle not running on the Cluster update/destroy pages

Eric Eastwood requested to merge 4378-fix-cluster-js-not-running-on-update-page into master

What does this MR do?

CE backport, https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/16506

  • Fix JS bundle not running on the Cluster update/destroy pages

Are there points in the code the reviewer needs to double check?

Steps to reproduce

For the update page,

  1. Add a cluster with environment set to example - Cluster1
  2. Add a cluster with environment set to not-example - Cluster2
  3. Open Cluster2 details page
  4. Attempt to change Cluster2 environment to example
  5. Click Save

from https://gitlab.com/gitlab-org/gitlab-ee/issues/4378

For the destroy page

  1. Modify https://gitlab.com/gitlab-org/gitlab-ee/blob/20ce2ec691cbc8c34aa7a24f55c5e8649a326e2e/app/controllers/projects/clusters_controller.rb#L62 so it always fails to destroy
  2. In the "Advanced settings" of the cluster, click the "Remove integration button"

How can I get this running ❓

Find the <<: *base section of gitlab.yml

development:
  <<: *base
  omniauth:
    providers:
      - { name: 'google_oauth2',
          app_id: '696404988091-ed2t2tm5sbggs799ekn7ujjq6i02qq4t.apps.googleusercontent.com',
          app_secret: '<see this message for secret https://gitlab.slack.com/archives/C72QLAA30/p1508257673000361>',
          args: { access_type: 'offline', approval_prompt: '' } }

Note: you can only have 1 cluster at a time

Start creating a cluster (located at <namespspace>/<project>/clusters/new)

In order to get the "Project ID", visit https://console.cloud.google.com/ and sign in with your GitLab acccount

Click the "Select a project" dropdown

Go to the "All" tab and use the project ID from gitlab-internal

from https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/15064

Why was this MR needed?

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Tests added for this feature/bug
    • Worth testing if bundle loaded (some JS feature in the bundle)?
  • Review
    • Has been reviewed by Frontend
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together
  • Internationalization required/considered
  • If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan

What are the relevant issue numbers?

Closes #4378 (closed)

Edited by Eric Eastwood

Merge request reports