More verbose error message when creating extension
What does this MR do?
This adds a migration helper to create (and drop) a postgres extension. It is meant to provide a more helpful error message in case the extension cannot be created (or dropped) due to missing privileges.
See #243729 (closed) for more background.
This also adds a documentation page to explain this problem in more detail.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Closes #243729 (closed)
Merge request reports
Activity
changed milestone to %13.4
added database groupdatabase labels
added databasereview pending label
2 Messages 📖 This merge request adds or changes files that require a review from the Technical Writing team. 📖 CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 40956 "More verbose error message when creating extension"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 40956 "More verbose error message when creating extension"
If this merge request doesn’t need a CHANGELOG entry, feel free to ignore this message.
Documentation review
The following files require a review from a technical writer:
doc/install/postgresql_extensions.md
doc/install/requirements.md
doc/update/README.md
The review does not need to block merging this merge request. See the:
- Technical Writers assignments for the appropriate technical writer for this review.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer database Patrick Bair ( @pbair
) (UTC-4, 6 hours behind@abrandl
)Yannis Roussos ( @iroussos
) (UTC+3, 1 hour ahead of@abrandl
)backend Saikat Sarkar ( @ssarka
) (UTC-6, 8 hours behind@abrandl
)Dmitriy 'DZ' Zaporozhets ( @dzaporozhets
) (UTC+3, 1 hour ahead of@abrandl
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖added 1 commit
- c79f6d42 - More verbose error message when creating extension
added documentation label
added 31 commits
-
883bd413...63a26a05 - 29 commits from branch
master
- 5e052184 - More verbose error message when creating extension
- 19ba5819 - Add documentation for managing PG extensions
-
883bd413...63a26a05 - 29 commits from branch
mentioned in issue #243729 (closed)
- Resolved by Andreas Brandl
@iroussos Can you please review the database side?
@axil Can you please take a look at the added documentation page? Is there a better place to put it? Also, I'm not sure why https://gitlab.com/gitlab-org/gitlab/-/jobs/713967158 failed or how to fix it - in case that's obvious to you, I'd appreciate a hint. :) Thanks!
added databaseapproved label and removed databasereview pending label
- Resolved by Andreas Brandl
- Resolved by Andreas Brandl
- Resolved by Andreas Brandl
- Resolved by Andreas Brandl
- Resolved by Andreas Brandl
unassigned @iroussos