Fix SameSite=None incompatible check not working
!40667 (merged) didn't
actually work because we need to read the Rack HTTP_USER_AGENT
entry from the request
headers instead of the response headers.
Relates to #241785 (closed)
Merge request reports
Activity
changed milestone to %13.4
added typefeature label
added 174 commits
-
ac791076...fdc00989 - 173 commits from branch
master
- f78c68b0 - Fix SameSite=None incompatible check not working
-
ac791076...fdc00989 - 173 commits from branch
- Resolved by Peter Leitzen
added 1 commit
- 031e2392 - Fix SameSite=None incompatible check not working
assigned to @splattael and unassigned @stanhu
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Amy Troschinetz ( @atroschinetz
) (UTC-7, same timezone as@stanhu
)Douglas Barbosa Alexandre ( @dbalexandre
) (UTC-4, 3 hours ahead of@stanhu
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖assigned to @stanhu and unassigned @splattael
30 30 set_cookie = headers['Set-Cookie']&.strip 31 31 32 32 return result if set_cookie.blank? || !ssl? 33 return result if same_site_none_incompatible?(headers['User-Agent']) 33 return result if same_site_none_incompatible?(env['User-Agent']) changed this line in version 4 of the diff
added 1 commit
- 0851e565 - Fix SameSite=None incompatible check not working
added 1 commit
- 3f11dde5 - Fix SameSite=None incompatible check not working
- Resolved by Peter Leitzen
assigned to @splattael and unassigned @stanhu
mentioned in merge request !40667 (merged)
added sectiondev label
enabled an automatic merge when the pipeline for 1ac740a7 succeeds
mentioned in commit 670db777
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
This merge request has been deployed to the pre.gitlab.com environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.
This comment is generated automatically using the Release Tools project.added published label
This merge request has been deployed to the release.gitlab.net environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.
This comment is generated automatically using the Release Tools project.removed typefeature label