Recognise links to urls in job logs
What does this MR do?
This is a partial solution to #18324 (closed) - transform plain-text URLs to clickable links.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) I'm not sure if required and I can't find linked section ( #when-documentation-is-required
), I don't think I do need a documentation for that. -
Code review guidelines -
Merge request performance guidelines The work is done on client-side and log is limited to a certain number of lines, so it should be fine, right? -
Style guides 😦 it appears thatinnerHTML
should be avoided, I'll rewrite to avoid this, however, will this be really a safety improvement? -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - ❓ should I write some unit tests for that? -
Tested in all supported browsers https://soapbox.github.io/linkifyjs/docs/#internet-explorer it appears that everything above IE 8 is supported -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Part of #18324 (closed)
Edited by Łukasz Groszkowski