Skip to content

Refactor(VSA filter bar): use general filter bar

What does this MR do?

This MR changes the VSA (cycle analytics) page to use the general filtered_search_bar.vue instead of our own implementation.

This is a stepping stone towards implementing a general filter bar solution for analytics.

In changing to use this general implementation, we get recent searches feature for free. No ticket was created for this effort. It also fixes an issue where the filter would not get populated properly from the URL (this is a recent bug), see screenshots. In order to do this, a few actions needed to be corrected.

In order to use this general solution, the filter bar is moved to its own row to give it more space for the many options.

Note: This filter bar is behind the following feature flags: value_stream_analytics_path_navigation and value_stream_analytics_filter_bar. Ensure they are turned on before testing this out. This is also the reason why there is no changelog entry.

Screenshots

Before: After:
Screen_Recording_2020-08-17_at_13.45.39 Screen_Recording_2020-08-17_at_13.27.51

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

This implementation is fairly safe as it uses a component that is in use in other places, over a specific implementation of the same. The feature tests also pass with very few modifications, which is reassuring.

To test this out navigate to, e.g. this URL: http://127.0.0.1:3000/groups/flightjs/-/analytics/value_stream_analytics?project_ids%5B%5D=6&created_after=2020-07-19&created_before=2020-08-17&milestone_title=Upcoming&label_name%5B%5D=Bryffe&assignee_username%5B%5D=root

and this URL: http://127.0.0.1:3000/-/analytics/value_stream_analytics?group_id=flightjs&created_after=2020-07-20&created_before=2020-08-18&label_name%5B%5D=Accord&label_name%5B%5D=Bryffe

Known issues:

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #232465 (closed)

Edited by Michael Lunøe

Merge request reports