Move Analytics to admin panel
What does this MR do?
This MR moves instance related Analytics section from the top bar navigation to the Admin panel, with pages
Admin > Analytics > DevOps Score-
Admin > Analytics > Cohorts.
It removes Analytics icon from the top bar navigation.
It removes the toggle to make instance related analytics visible to non-admin users from Admin > Settings > Metrics and profiling > Usage statistics, as these analytics should be visible to admins only.
With that, it ignores the column instance_statistics_visibility_private as the first step towards the removal of the column and removes now obsolete application setting.
This MR solves: #233833 (closed), and the follow ups #205909 (closed) and #224716 (closed), in order to give a good user experience to Admins (links leading to pages). This MR doesn't have documentation changes, which will be added in a follow up MR, to split concerns !39855 (merged).
In order to be backwards compatible, for one release we keep the old paths, but redirect them to pages under Admin menu
'-/instance_statistics/dev_ops_score', to: redirect('/admin/dev_ops_score')
'-/instance_statistics/cohorts', to: redirect('/admin/cohorts')
'/instance_statistics', to: redirect('/admin/dev_ops_score')
'/analytics', to: redirect('/admin/dev_ops_score')The quite substantial number of files changed results from many deletions and file movements, the additions are not that many.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team