Skip to content

Skip reference processing for PersonalSnippet Notes

Vijay Hawoldar requested to merge vij-snippet-note-updates into master

What does this MR do?

When updating a Note, the update service attempts to update/create any new cross reference mentions, generate Todos and create Suggestions (here).

With PersonalSnippets, none of these are required.

References: At the time of writing, PersonalSnippets do not generate GFM references to resources (although work is being carried out on that, here, which is how this MR came about)

Todos: Notes on Snippets should/do not generate Todos, see this check

Suggestions: Notes on Snippets do not support suggestions

Previously, this was not a problem (besides the unnecessary method calls), but with the introduction of references in PersonalSnippets, we need to skip this entirely to avoid creating mentions on resources that should not be present, when updating a Note on a PersonalSnippet.

This MR addresses that by adding an additional check for_personal_snippets?, in a similar way to how it's handled for Note creation, here

No changelog has been added as this change is developer facing only. References, todos and suggestions are not supported on PersonalSnippets currently.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Edited by Vijay Hawoldar

Merge request reports