Skip reference processing for PersonalSnippet Notes
What does this MR do?
When updating a Note, the update service attempts to update/create any new cross reference mentions, generate Todos and create Suggestions (here).
With PersonalSnippets, none of these are required.
References: At the time of writing, PersonalSnippets do not generate GFM references to resources (although work is being carried out on that, here, which is how this MR came about)
Todos: Notes on Snippets should/do not generate Todos, see this check
Suggestions: Notes on Snippets do not support suggestions
Previously, this was not a problem (besides the unnecessary method calls), but with the introduction of references in PersonalSnippets, we need to skip this entirely to avoid creating mentions on resources that should not be present, when updating a Note on a PersonalSnippet.
This MR addresses that by adding an additional check for_personal_snippets?
, in a similar way to how it's handled for Note creation, here
No changelog has been added as this change is developer facing only. References, todos and suggestions are not supported on PersonalSnippets currently.
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done