GFM references doesn't work inside personal snippets
Please note:
The changes required to address this issue will be completed behind the feature flag :personal_snippet_reference_filters
.
This is to ensure a consistent user experience until all changes are complete (reference filtering, previewing, background migration of existing content)
If we add a link to a project, snippet, issue, merge request, or any other object whose link can be converted into a reference, to a comment inside a personal snippet the URL doesn't get replaced with the object reference.
Process:
- Create/View a personal snippet
- Add a link to a project inside the personal snippet
- The URL is not replaced with the project reference
Testing Activity
- Check that a link to a personal snippet is replaced by a GFM reference. Besides, we need to ensure that a reference to another user's personal snippet also has the format
user$snipept_id
.
MR Breakdown
- This issue can be tricky. It seems most of the GFM code assumes that resources are attached to projects or groups. Therefore, introducing a resource that is not attached to any of them but the user can be tricky.
-
Looks like the AbstractReferenceFilter may need refactoring not to exclude resources that don't have a project/group associated with them.
-
1+ MRs due to an investigation being required to establish extent of the problem / potential solution
-
Some cross-over/relation to #217306 (closed)
Please see #217305 (comment 387284852), below, for a breakdown of what's required for this issue