Skip to content
Snippets Groups Projects

GitLab UI: 872-merge-glskeletonloading-into-glskeletonloader integration test

What does this MR do?

Updates a snapshot test to account for changes to GLSkeletonLoader. The markup for this snapshot test shouldn't actually be changing but originally it was taken using shallowMount which caused the snapshot to use the component stub. With VTU component stubs display props as HTML attributes. Since we added some props to the GLSkeletonLoader component it causes the test to fail. This MR changes to using mount as it seems like a more reliable test in this case.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman

Merge request reports

Merged results pipeline #182321512 passed

Merged results pipeline passed for 84ae93ef

Test coverage 56.25% (0.00%) from 2 jobs

Merged by Jose Ivan VargasJose Ivan Vargas 4 years ago (Aug 26, 2020 5:55pm UTC)

Loading

Pipeline #182342988 passed

Pipeline passed for a137b684 on master

Test coverage 56.25% (0.00%) from 2 jobs
5 environments impacted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading