Skip to content

Read Only Legacy Feature Flags

Jason Goodman requested to merge read-only-legacy-feature-flags into master

What does this MR do?

Adds the code for making legacy feature flags Read-Only.

This flag will not be enabled until %13.4.

Issue: #220228 (closed)

See also: #220227 (closed)

Screenshots

Index page:

  • The toggles for legacy flags are disabled.

Screen_Shot_2020-07-30_at_4.18.30_PM

Tooltip on the index page:

Screen_Shot_2020-07-30_at_4.43.36_PM

Edit page:

  • The message at the top of the screen says the flag is read-only.
  • The Save button is disabled.

Screen_Shot_2020-07-30_at_4.19.12_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jason Goodman

Merge request reports