Defer stackprof signal trap when running in sidekiq
What does this MR do?
This is an amendment to !35993 (merged).
Stackprof is currently not working on sidekiq processes (or specifically, it is only working while the application is loading).
I was able to track this down to sidekiq trapping USR2 (despite only using it in sidekiq pro), and doing so after the app has been loaded, which means the initializer-based trap gets overridden (source).
I opened an upstream MR, but we should also do something about this on our end in the mean time.
Sidekiq has a concept of lifecycle events that allows code to run after those signals have been trapped. Since the stackprof handler is set up via on_worker_start, deferring it until after app load will allow us to get our signal trap back.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
refs #225473 (closed) https://gitlab.com/gitlab-com/gl-infra/infrastructure/-/issues/10789