Fix local tiller default enabled inconsistency
What does this MR do?
Fixes an inconsistency missed in !35562 (merged) where we set the feature flag to default enabled.
I added ~"Pick into 13.2" because the documentation was already changed, and the backend will use local Tiller regardless of the Helm app being installed or not.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
- [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
- [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %13.3
added backend devopsconfigure [DEPRECATED] groupconfigure [DEPRECATED] typebug + 1 deleted label
1 Warning ⚠ You’ve made some app changes, but didn’t add any tests.
That’s OK as long as you’re refactoring existing code,
but please consider adding any of the ~”tooling”, ~”tooling::pipelines”, ~”tooling::workflow”, ~”documentation”, ~”QA” labels.Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Tiger Watson ( @tigerwnz
) (UTC+10, 14 hours ahead@hfyngvason
)Shinya Maeda ( @dosuken123
) (UTC+7, 11 hours ahead@hfyngvason
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖Thanks @hfyngvason - LGTM! Just need a changelog :)
marked the checklist item Changelog entry as completed
marked the checklist item Code review guidelines as completed
enabled an automatic merge when the pipeline for 92ef6a8e succeeds
mentioned in commit 6ac2167a
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in issue #209736 (closed)
mentioned in commit 880f0aff
mentioned in commit 49a37387