Fix behavior of license approvals status
requested to merge dpisek-fix-behavior-of-license-approval-status-on-policy-management-page into master
What does this MR do?
It fixes the behaviour of the inactive / active status that indicates if the license-approval rule has been configured to be in effect or not:
Currently it shows as active, even if the number of required approvals is 0.
The desired behaviour is that it only shows as active if the number of approvals is greater than 0 and at least one approver has been added.
Further information: #32149 (comment 380644573)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by David Pisek