Skip to content

Add not null constraint on User#preferred_language

Kassio Borges requested to merge kassio/add-user-default-language into master

What does this MR do?

Users created before 9.2 can have the preferred_language empty (NULL). This way, on the User preferences screen, an user might update the their language to Bulgarian, the first language of the language selector. To avoid that, and possible other problems, the preferred_language is marked as a not null and the users with empty preferred_language will be updated to the system default language (I18n.default_locale).

Screenshots

$ bundle exec rails db:migrate
== 20200716093825 AddUsersDefaultValueOnPreferredLanguage: migrating ==========
-- change_column_default(:users, :preferred_language, {:from=>nil, :to=>:en})
   -> 0.0074s
== 20200716093825 AddUsersDefaultValueOnPreferredLanguage: migrated (0.0075s) =

== 20200716094825 AddNotNullConstraintToUsersPreferredLanguage: migrating =====
-- transaction_open?()
   -> 0.0000s
-- execute("ALTER TABLE users\nADD CONSTRAINT check_b8a6498b68\nCHECK ( preferred_language IS NOT NULL )\nNOT VALID;\n")
   -> 0.0037s
== 20200716094825 AddNotNullConstraintToUsersPreferredLanguage: migrated (0.0198s)

== 20200716095811 BackfillUserPreferredLanguage: migrating ====================
== 20200716095811 BackfillUserPreferredLanguage: migrated (0.0747s) ===========

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Kassio Borges

Merge request reports