GitLab users have bulgarian language set in profile after upgrade to 13.0.5
Summary
GitLab users have bulgarian
language set in profile preferences after the upgrade, This might have introduced in an earlier version as well. After investigation, Found out that, language is not actually set in the DB, It's only the UI which shows as a default option. This could cause issues if the user changed any other preferences and click save button without noticing the default language option. This issue is visible on gitlab.com as well. This happens when preferred_language
is set to NULL.
Steps to reproduce
- Login to GitLab.com
- Navigate to profile pref
- Navigate to Localization
What is the current bug behavior?
GitLab users have bulgarian
language as a default option in profile preferences
What is the expected correct behavior?
This should either have been empty or set to English so that visiting profile prefs (doing nothing) and click save button should not change the preferred_language
in DB.
Relevant logs and/or screenshots
Output of checks
This bug happens on GitLab.com
Preferred solution
- Leave
English
in its current place on the list. - Default the UI to
English
(visually) when language is not set in the DB (NULL
). (Otherwise, show the actually selected language - current behavior) - Saving the user preferences would either save
English
, or leaveNULL
- same effect. - New users would continue to be created with
NULL
default for their language preference.