Update Project deletion copy based on deletion mode
What does this MR do?
We changed the default mode of Project Deletion from Delayed Deletion
to Delete Immediately
in !35689 (merged). Group admins have an ability to toggle it in the Group Settings.
In addition, we also need to update the copy of the Delete modal to indicate whether the Project will be deleted with a delay or immediately (this can be retrieved from the Group's Setting for delayed_project_removal
).
This MR updates the copy text based on the current configuration, the design will be updated in #220243 (closed).
Mentions #220382 (closed)
Feature flag removal
The feature flag configure_project_deletion_mode
was introduced to ensure both the MRs are released to the users at the same time.
This MR removes the feature, since it is no longer needed with this merge.
Screenshots
After (delayed deletion + delete immediately mode)
Mode | Delete Section | Delete Modal |
---|---|---|
Delayed Deletion | ||
Delete immediately |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team