Skip to content
Snippets Groups Projects

Removed deprecated ECS template

Merged Etienne Baqué requested to merge 220821-remove-deprecated-ecs-template into master

What does this MR do?

This MR removes the deprecated ECS template, located at lib/gitlab/ci/templates/Deploy-ECS.gitlab-ci.yml, in favor of the one located at lib/gitlab/ci/templates/AWS/Deploy-ECS.gitlab-ci.yml.

Manual testing

https://gitlab.com/ebaque/rails-docker-ecs/-/jobs/630009571

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #220821 (closed)

Edited by Thong Kuah

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Etienne Baqué added 188 commits

    added 188 commits

    Compare with previous version

  • Author Maintainer

    @hfyngvason Can you please review this small MR?

  • Etienne Baqué assigned to @hfyngvason and unassigned @ebaque

    assigned to @hfyngvason and unassigned @ebaque

  • Thanks @ebaque! I had a few questions and suggestions, let me know what you think :ping_pong:

  • assigned to @ebaque and unassigned @hfyngvason

  • Etienne Baqué added 286 commits

    added 286 commits

    Compare with previous version

  • Etienne Baqué added 1 commit

    added 1 commit

    • 734b8905 - Added error stage to deprecated template

    Compare with previous version

  • 1 Message
    :book: This merge request adds or changes files that require a review from the Technical Writing team.

    Documentation review

    The following files require a review from a technical writer:

    • doc/ci/cloud_deployment/index.md

    The review does not need to block merging this merge request. See the:

    Reviewer roulette

    Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.

    Category Reviewer Maintainer
    backend Vasilii Iakliushin (@vyaklushin) (UTC+2, 6 hours ahead @ebaque) Peter Leitzen (@splattael) (UTC+2, 6 hours ahead @ebaque)

    If needed, you can retry the danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

    Edited by 🤖 GitLab Bot 🤖
  • Etienne Baqué added 1 commit

    added 1 commit

    • 4e5a6058 - Added error stage to deprecated template

    Compare with previous version

  • Etienne Baqué added 1 commit

    added 1 commit

    • 2907411e - Added error stage to deprecated template

    Compare with previous version

  • Etienne Baqué added 1 commit

    added 1 commit

    • 2ef4b77c - Added error stage to deprecated template

    Compare with previous version

  • Etienne Baqué changed the description

    changed the description

  • Etienne Baqué added 1 commit

    added 1 commit

    • 88d83887 - Added error stage to deprecated template

    Compare with previous version

  • Etienne Baqué added 1 commit

    added 1 commit

    • bfe65523 - Added error stage to deprecated template

    Compare with previous version

  • Etienne Baqué assigned to @hfyngvason and unassigned @ebaque

    assigned to @hfyngvason and unassigned @ebaque

  • Etienne Baqué added 1 commit

    added 1 commit

    • 244bfbb0 - Added error stage to deprecated template

    Compare with previous version

  • Thanks @ebaque! The code looks good to me, but there's still the one outstanding question in !36143 (comment 375204047)

  • assigned to @ebaque and unassigned @hfyngvason

  • Etienne Baqué assigned to @hfyngvason and unassigned @ebaque

    assigned to @hfyngvason and unassigned @ebaque

  • Hordur Freyr Yngvason resolved all threads

    resolved all threads

  • Hordur Freyr Yngvason approved this merge request

    approved this merge request

  • assigned to @ebaque and unassigned @hfyngvason

  • assigned to @tkuah

  • added workflowin review label and removed workflowin dev label

  • Thong Kuah marked the checklist item Changelog entry as completed

    marked the checklist item Changelog entry as completed

  • Thong Kuah
  • unassigned @tkuah

  • Etienne Baqué assigned to @tkuah and unassigned @ebaque

    assigned to @tkuah and unassigned @ebaque

  • Thong Kuah
  • Thong Kuah assigned to @ebaque and unassigned @tkuah

    assigned to @ebaque and unassigned @tkuah

  • Etienne Baqué added 2079 commits

    added 2079 commits

    Compare with previous version

  • Etienne Baqué added 1 commit

    added 1 commit

    • 2aab8d29 - Added error stage to deprecated template

    Compare with previous version

  • Etienne Baqué added 1 commit

    added 1 commit

    • 72889165 - Added error stage to deprecated template

    Compare with previous version

  • Etienne Baqué added 28 commits

    added 28 commits

    Compare with previous version

  • Etienne Baqué assigned to @tkuah and unassigned @ebaque

    assigned to @tkuah and unassigned @ebaque

  • Thong Kuah resolved all threads

    resolved all threads

  • Thong Kuah marked the checklist item Documentation (if required) as completed

    marked the checklist item Documentation (if required) as completed

  • Thong Kuah approved this merge request

    approved this merge request

  • Thong Kuah enabled an automatic merge when the pipeline for 74b7f79d succeeds

    enabled an automatic merge when the pipeline for 74b7f79d succeeds

  • Thong Kuah canceled the automatic merge

    canceled the automatic merge

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading