Removed deprecated ECS template
What does this MR do?
This MR removes the deprecated ECS template, located at lib/gitlab/ci/templates/Deploy-ECS.gitlab-ci.yml
, in favor of the one located at lib/gitlab/ci/templates/AWS/Deploy-ECS.gitlab-ci.yml
.
Manual testing
https://gitlab.com/ebaque/rails-docker-ecs/-/jobs/630009571
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #220821 (closed)
Merge request reports
Activity
changed milestone to %13.2
- Resolved by Hordur Freyr Yngvason
added 188 commits
-
c55a896f...db775720 - 187 commits from branch
master
- 39d2a71a - Removed deprecated ECS template
-
c55a896f...db775720 - 187 commits from branch
@hfyngvason Can you please review this small MR?
assigned to @hfyngvason and unassigned @ebaque
- Resolved by Hordur Freyr Yngvason
- Resolved by Hordur Freyr Yngvason
@ebaque This is technically a breaking change with very little advanced notice. Are we ok with that?
- Resolved by Hordur Freyr Yngvason
There are still some mentions of
Deploy-ECS.gitlab-ci.yml
in the docs. Can we change them too?
Thanks @ebaque! I had a few questions and suggestions, let me know what you think
assigned to @ebaque and unassigned @hfyngvason
added 286 commits
-
39d2a71a...0382457b - 284 commits from branch
master
- 0c9d73a9 - Removed deprecated ECS template
- fe84a60c - Added error stage to deprecated template
-
39d2a71a...0382457b - 284 commits from branch
1 Message This merge request adds or changes files that require a review from the Technical Writing team. Documentation review
The following files require a review from a technical writer:
doc/ci/cloud_deployment/index.md
The review does not need to block merging this merge request. See the:
- Technical Writers assignments for the appropriate technical writer for this review.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Vasilii Iakliushin ( @vyaklushin
) (UTC+2, 6 hours ahead@ebaque
)Peter Leitzen ( @splattael
) (UTC+2, 6 hours ahead@ebaque
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖assigned to @hfyngvason and unassigned @ebaque
added documentation label
Thanks @ebaque! The code looks good to me, but there's still the one outstanding question in !36143 (comment 375204047)
assigned to @ebaque and unassigned @hfyngvason
assigned to @hfyngvason and unassigned @ebaque
- Resolved by Thong Kuah
Thanks @ebaque and @csouthard! Looks good to me
assigned to @ebaque and unassigned @hfyngvason
assigned to @tkuah
added workflowin review label and removed workflowin dev label
marked the checklist item Changelog entry as completed
- Resolved by Thong Kuah
- Resolved by Thong Kuah
Thanks @ebaque - Looks OK to me. Just one docs-related question above
unassigned @tkuah
- Resolved by Thong Kuah
added 2079 commits
-
244bfbb0...c4247c9c - 2077 commits from branch
master
- ced139b0 - Removed deprecated ECS template
- c8ac4d91 - Added error stage to deprecated template
-
244bfbb0...c4247c9c - 2077 commits from branch
added 28 commits
-
72889165...8760d9a4 - 26 commits from branch
master
- ebef38d8 - Removed deprecated ECS template
- fd85567d - Added error stage to deprecated template
-
72889165...8760d9a4 - 26 commits from branch
marked the checklist item Documentation (if required) as completed
enabled an automatic merge when the pipeline for 74b7f79d succeeds