Follow-up: Restructure SSH and PAT credential inventory tests
requested to merge 227033-follow-up-from-highlight-expired-ssh-or-pat-credentials-in-the-credential-inventory into master
What does this MR do?
As a follow-on from !35229 (comment 374088388), this MR restructures the existing credential inventory tests to move the testing of the view logic from feature tests to unit tests.
This makes the tests faster and is more in-line with our testing standards
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Closes #227033 (closed)
Edited by Robert Hunt