Follow-up from "Highlight expired SSH or PAT credentials in the credential inventory"
The following discussion from !35229 (merged) should be addressed:
-
@jiaan started a discussion: (+2 comments) Suggestion (non-blocking): WDYT about removing this shared spec here and below? It seems like the date display is already covered by the above spec
'shows the details with no revoked date'
.
The existing structure of the feature tests in ee/spec/support/shared_examples/features/credentials_inventory_shared_examples.rb
could be better placed as unit tests.
We should pull out the logical tests into unit tests under ee/spec/views/shared/credentials_inventory
and keep the overarching "does this all work together" tests in the shared examples.