Make QA maintainer mandatory if MR is only QA and author is an SET
requested to merge team-tasks-559-reviewer-roulette-quality-maintainer-is-required-for-qa-mrs into master
What does this MR do?
When MR has QA changes only, OR author is an SET, then the QA maintainer review is mandatory. In any other cases, it's optional (as today).
Testing matrix
-
When MR has only QA changes, author isn't an SET, QA maintainer review is mandatory: !36068 (comment 374246644) -
When MR includes QA changes among other changes, author isn't an SET, QA maintainer review is optional: !36070 (comment 374249974) -
I cannot test the case where the author is an SET, but that would make the QA maintainer review mandatory for both cases above.
Closes https://gitlab.com/gitlab-org/quality/team-tasks/-/issues/559.
Edited by Rémy Coutable