Skip to content

Allow all out of the box dashboards to be cloned (frontend)

Reuben Pereira requested to merge 212873-fix-frontend-cloning into master

What does this MR do?

In !35521 (merged), we introduced a new key called out_of_the_box_dashboard into the response of the metrics_dashboard.json API response. This key is set to true for all out of the box dashboards; common_metrics.yml, self_monitoring_default.yml, cluster_metrics.yml and pod_metrics.yml.

This MR changes the frontend to allow cloning of any dashboard which has out_of_the_box_dashboard set to true.

Note that cluster_metrics.yml does not appear in the list of dashboards on the metrics dashboard page since it is displayed on the K8s settings cluster health page. There is no way on the UI to clone this dashboard, but the backend does support cloning it.

pod_metrics.yml also does not appear in the list of dashboards since it is not yet ready to be used. It will be made public in #218649 (closed).

Issue: #212873 (closed)

Screenshots

image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Reuben Pereira

Merge request reports