Various UX improvements to the code navigation popover
What does this MR do?
Increases the width of the code navigation popover, given the popover a max width so that it doesn't overflow on mobile. I've also given the definition areas a max height so that the popover doesn't get too large, instead the user can scroll this part.
Change how code navigation underlines are shown. Instead of always showing, they now only get shown when the user hovers over a line and increase in color when the user hovers over the code navigation part.
Screen_Recording_2020-06-30_at_15.50.25
Added text that says This is the definition for popovers that are currently linking to themselves.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team