Skip to content

[EE] Strip leading & trailing whitespaces in CI/CD secret variable keys, and environment scope

Rémy Coutable requested to merge ee-40561-environment-scope-value-is-not-trimmed into master

EE MR for https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/15615.

What does this MR do?

  1. The CE MR ensures that the key of a secret variable is stripped of leading and trailing whitespaces.
  2. This EE MR ensure that the environment scope of a secret variable is stripped of leading and trailing whitespaces.

Why was this MR needed?

Because leading and trailing whitespaces should be stripped and can be confusing. See gitlab-ce#40561.

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by Backend
  • Conform by the style guides
  • Squashed related commits together
  • Internationalization required/considered
  • If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan

What are the relevant issue numbers?

Closes gitlab-ce#40561.

Merge request reports