Skip to content

Apply filter bar values to api requests

Ezekiel Kigbo requested to merge 217943-vsa-apply-filter-bar-values-to-api into master

What does this MR do?

  • Adds additional filter parameters to the cycleAnalyticsRequestParams getter
  • Applies the additional filter parameters to the value stream analytics api requests

NOTE: this requires the changes in !34598 (merged)

Feature flag

You will need to enable the value_stream_analytics_filter_bar to view the filter bar.

Testing instructions

The filter bar requires the value_stream_analytics_filter_bar feature flag and only applies to group level VSA (currently not project level)

  1. Navigate to any group ie /gruops/gitlab-org
  2. From the left side bar Navigate to Analytics > Value stream analytics
  3. Select a project from the dropdown, then the filter bar can be tested
  4. The query parameters should be updated to reflect your selection, and api requests sent
  5. After adding some parameters, copy the url and open it in a new tab, the filter bar should be returned to the same state

Note:

  • The disabled state for the filter bar isnt correctly reflected, but will be fixed

Screenshots

No visual changes

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #217943 (closed)

Edited by Ezekiel Kigbo

Merge request reports