Toggle a disabled state for the filter bar
What does this MR do?
Toggles the disabled state for the VSA filter bar.
- Replaces the filter bar with a GlSearchBoxByClick component with the disabled state set
- Toggles between the search box and filtered search when the disabled state changes (when a project is selcted)
Screenshots
Screen_Recording_2020-06-18_at_6.59.58_pm
Testing instructions
The filter bar requires the value_stream_analytics_filter_bar feature flag and only applies to group level VSA (currently not project level)
- Navigate to any group ie
/gruops/gitlab-org - From the left side bar Navigate to
Analytics>Value stream analytics - The filter bar should be disabled and you can not interact with it
- Select a project from the dropdown
- The filter bar should become active
Note:
- Filters are not applied to the VSA api requests, this will be in a subsequent MR
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #222347 (closed) Related to #217943 (closed)
Edited by Ezekiel Kigbo