Remove GitlabIssueTrackerService class
What does this MR do?
It removes the GitlabIssueTrackerService class and all references. It does not delete service records with type GitlabIssueTrackerService in the database yet. I thought about adding a migration for this but thought it would be good to do this in a separate step to make reviews easier
I tried removing it before in !28219 (closed) but it was too unclear if it was still in use. Since then, I made sure GitlabIssueTrackerService is not used any more in IssuesHelper (!32330 (merged)) and SystemNotes::IssuablesService (!33263 (merged)). I couldn't find other places that would use it and I now think we are good to remove the class.
Part of #218526 (closed)
Why?
I'm working on cleaning up the services table (#211785 (closed)). There are 998778 records with type GitlabIssueTrackerService on staging and it is likely that the number on production and self managed instances is also very high. The GitlabIssueTrackerService was once used as the default issue tracker but it is not used anymore.
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team