Skip to content

Use internal issue url unless external tracker

Andy Schoenen requested to merge use_url_helpers_for_internal_issues into master

What does this MR do?

TL;DR: This MR should not change the way we generate issue_url, just the underlying code so it is not possible to call GitlabIssueTrackerService anymore.

In !28219 (closed) I tried to remove the GitlabIssueTrackerService. It is the default issue tracker service but it looks like it is not used anymore. There are still some places where it could be called. For example when IssuesHelper.url_for_issue is called with an internal issue and without the internal option. Except for specs, I couldn't find a place where this would actually happen but just to be safe, this MR changes it to use url_helpers over GitlabIssueTrackerService when there is no external issue tracker.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports