Skip to content

Put Batched Suggestions behind a Feature Flag default to false

André Luís requested to merge andr3-disable-batch-if-uneven-line-count into master

What does this MR do?

In order to prevent unpredictable and incorrect application of suggestions when using the recent Add suggestion to Batch feature, this MR disables the Add to Batch button when the line count will be changed by applying the suggestion.

Update: we ended up wrapping the UI button behind a feature flag.

Screenshots

Feature flag disabled (default) Feature flag enabled
Screen_Shot_2020-06-17_at_4.46.10_PM Screen_Shot_2020-06-17_at_4.55.06_PM
Outdated screenshot

This was before we switched to putting it behind a feature flag

Screenshot_2020-06-17_at_20.53.17

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Addresses #222780 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading