Batched suggestions get applied in wrong location
I discovered that my batched suggestion was applied on the wrong line. Compare the suggestion:
- - [ ] If some reviewers have not yet approved or commented, wait until the time window expires before taking action.
+ - [ ] Wait until the time window expires before taking action to give others a chance to comment.
gitaly!2259 (comment 361733915)
...with the actual committed change:
- - [ ] If you choose to make changes, ping the existing approvers so that they may review the changes.
+ - [ ] Wait until the time window expires before taking action to give others a chance to comment.
The change was applied two lines down from where it was intended.
This may be related to another suggestion in the same batch that changed the number of lines above the affected suggestion:
- - [ ] Assign reviewers based on expertise and the impact of the RFC.
- - [ ] Require a minimum of 2 maintainer approvals. Increase if warranted.
- - [ ] Once ready for review, announce the RFC to the Gitaly team (`/cc @gl-gitaly`)
+ - [ ] Require a minimum of 2 maintainer approvals. Increase if warranted.
+ - [ ] Once ready for review, announce the RFC to the Gitaly team (`/cc @gl-gitaly`)
Edited by Robert Speicher