Enable AllowImplicitReturn:false for Rails/SaveBang rubocop rule
What does this MR do?
In previous MR, we enabled Rails/SaveBang
for test files.
In this MR, we are enabling AllowImplicitReturn:false
feature of this cop. This cop prevents the usage of this:
before do
obj.update(key: val)
end
Also, I added ActionDispatch::TestRequest
into AllowedReceivers
to prevent accidental usage of create!
.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team