Skip to content

Enable AllowImplicitReturn:false for Rails/SaveBang rubocop rule

Furkan Ayhan requested to merge improve-usage-of-Rails-SaveBang into master

What does this MR do?

In previous MR, we enabled Rails/SaveBang for test files.

In this MR, we are enabling AllowImplicitReturn:false feature of this cop. This cop prevents the usage of this:

before do
  obj.update(key: val)
end

Also, I added ActionDispatch::TestRequest into AllowedReceivers to prevent accidental usage of create!.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports