Replace attach icon and address space
What does this MR do?
Similar to !34196 (merged), this replaces an instance of a FontAwesome icon with a GitLab SVG. It also addresses spacing issues between the icon and text in a similar instance.
Item | Before | After |
---|---|---|
New issue/MR icon | ||
Icon spacing | ||
Error message | ||
Vertical alignment | ||
Loading state |
To validate
- Create a new issue and make sure 'Attach a file' looks correct.
- Add a comment to the issue and make sure 'Attach a file' looks correct.
- Use the 'Attach a file' button to upload a file, make sure the progress info looks correct.
- Edit the issue and make sure 'Attach a file' looks correct.
- Repeat the above steps for a merge request.
In the browser inspector you can also display the progress and error elements by removing the .hide
class.
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
N/A
Security
N/A
Closes #223187 (closed)
Edited by Taurie Davis