Skip to content

Replace attach icon and address space

Jeremy Elder requested to merge fix-attach-file-icon-margin into master

What does this MR do?

Similar to !34196 (merged), this replaces an instance of a FontAwesome icon with a GitLab SVG. It also addresses spacing issues between the icon and text in a similar instance.

Item Before After
New issue/MR icon CleanShot_2020-06-11_at_10.30.57_2x CleanShot_2020-06-11_at_10.31.17_2x
Icon spacing CleanShot_2020-06-11_at_10.31.48_2x CleanShot_2020-06-11_at_10.31.17_2x
Error message CleanShot_2020-06-18_at_09.41.59_2x CleanShot_2020-06-18_at_09.41.41_2x
Vertical alignment CleanShot_2020-06-18_at_11.34.12_2x CleanShot_2020-06-18_at_11.34.56_2x
Loading state CleanShot_2020-06-18_at_10.14.58_2x CleanShot_2020-06-18_at_10.15.24_2x

To validate

  1. Create a new issue and make sure 'Attach a file' looks correct.
  2. Add a comment to the issue and make sure 'Attach a file' looks correct.
  3. Use the 'Attach a file' button to upload a file, make sure the progress info looks correct.
  4. Edit the issue and make sure 'Attach a file' looks correct.
  5. Repeat the above steps for a merge request.

In the browser inspector you can also display the progress and error elements by removing the .hide class.

Conformity

Availability and Testing

N/A

Security

N/A

Closes #223187 (closed)

Edited by Taurie Davis

Merge request reports