fix(api): include standard Link header in keyset pagination
What does this MR do?
Adds the standard LinkHeader to keyset pagination and depreciate the Links
header.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
added 1 commit
- 8132c6a0 - fix(api): include standard Link header in keyset pagination
mentioned in issue #218504 (closed)
added Category:API Community contribution api backend labels
- Resolved by Sean McGivern
@max-wittig I was scrolling through our bug backlog and found this MR which seems to fix: #218504 (closed). Thank you!
Please let me know if you need any help with this Community contribution and I hope you don't mind me adding some labels
added 1 commit
- 708b6663 - fix(api): include standard Link header in keyset pagination
added 1 commit
- 22cbe5aa - fix(api): include standard Link header in keyset pagination
added 28 commits
-
22cbe5aa...a45b8ff8 - 27 commits from branch
gitlab-org:master
- 6f0d1029 - fix(api): include standard Link header in keyset pagination
-
22cbe5aa...a45b8ff8 - 27 commits from branch
marked the checklist item Changelog entry as completed
marked the checklist item Documentation (if required) as completed
marked the checklist item Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. as completed
added 1 commit
- e8e3ee94 - fix(api): include standard Link header in keyset pagination
assigned to @brytannia
mentioned in issue #220312 (closed)
I've created an issue to remove
Links
header in 14.0 #220312 (closed)thanks, @max-wittig for fixing it
The changes look clean and straight forward, I'm approving this MR and moving it to Maintainer review.@smcgivern could you please take a look?
unassigned @brytannia
assigned to @smcgivern
- Resolved by Max Wittig
Thanks @max-wittig, this is great! I think I reviewed the MR that added this but obviously I missed the typo
changed milestone to %13.1
mentioned in commit 0901d4b2
mentioned in issue gitlab-com/gl-infra/scalability#408
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in merge request !62388 (merged)
mentioned in commit b702e218
mentioned in commit 47203a78
mentioned in commit python-gitlab/python-gitlab@7b61ae6a
mentioned in commit python-gitlab/python-gitlab@77c04b1a
added linked-issue label
added Leading Organization label