Skip to content

Display confirm modal before leaving Static Site Editor

Enrique Alcántara requested to merge 216865-confirm-leave-site into master

What does this MR do?

Displays a confirmation modal when the user attempts to leave the Static Site Editor and there are unsaved changes.

CAVEAT: Currently, The Rich Content Editor removes the last empty line of a page’s source automatically. This is a bug in Toast UI and causes the editor to detect "changes" as soon as the editor is initialized.

Screenshots

Showing different browsers because all of them show a different message 🤷

Firefox Chrome
Screen_Shot_2020-05-26_at_3.45.03_PM Screen_Shot_2020-05-26_at_3.45.22_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #216865 (closed)

Edited by Enrique Alcántara

Merge request reports