Assign alerts sidebar container fix
What does this MR do?
This is merge 2/2 for: #218404 (closed)
See #218404 (comment 345803729) for progression plan and caveeats.
These three merges are designed to provide the base of the rest of the work for: &3349 (closed)
In this merge we do a one thing:
- Add the correct parent container classes to format the padding of the layout correctly with two sidebars.
We want to provide the most boring possible solution, clearing a clear path to progression in an iteration based approach. This is done by doing to main things:
UX => We attempt to keep this sidebar as close to the current versions as possible in the app.
frontend => We opt to make use of a classList toggle to apply the right classes for the parent containers.
Notes && Known Issues
- Our container now formats correctly with same padding as issues and merge requests
🤘 - Sidebar opens by default(even on mobile), which is a ~bug but I will handle this in a separate merge request.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
~"workflow::In review" Deliverable frontend feature ~"group::health" devopsmonitor ~"Category:Alert Management"