Skip to content

Check user permissions when updating alert status

Peter Leitzen requested to merge pl-alert-management-status-service-auth into master

What does this MR do?

This MR follows up !30505 (merged) and #216746 (closed) and adds an extra permission check to AlertManagement::UpdateAlertStatusService.

While at it, this MR also 💅 streamlines the service and its specs a bit.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Rémy Coutable

Merge request reports