Organize package models by package type
What does this MR do?
Related to #216719 (closed)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
mentioned in issue #216719 (closed)
assigned to @10io
assigned to @ksashikumar
added Community contribution label
added devopspackage grouppackage registry labels
added workflowin dev label
changed milestone to %13.0
- Resolved by David Fernandez
- Resolved by Mayra Cabrera
- Resolved by Mayra Cabrera
- Resolved by Sashi
added 1 commit
- 9029a808 - Apply suggestion to changelogs/unreleased/sk-organize-package-models.yml
added 180 commits
-
9029a808...f7d46e8a - 177 commits from branch
gitlab-org:master
- 6409690c - Organize package models by package type
- c4225994 - Apply suggestion to changelogs/unreleased/sk-organize-package-models.yml
- 3bc81d1a - Add table_name_prefix instead of table_name
Toggle commit list-
9029a808...f7d46e8a - 177 commits from branch
assigned to @mayra-cabrera and unassigned @10io
added workflowin review label and removed workflowin dev label
- Resolved by Mayra Cabrera
What do you think if we rebase against
master
to include the changes introduced by !30618 (merged)? That MR added a new modelPackages::NugetDependencyLinkMetadatum
that can be relocated toPackages::Nuget::DependencyLinkMetadatum
?cc @10io
- Resolved by Mayra Cabrera
Thank you so much for your contribution @ksashikumar
! Code looks great! I've left one suggestion for you !31346 (comment 339300987), could you please take a look?Please ping me when this is ready for another review
unassigned @mayra-cabrera
added 104 commits
-
3bc81d1a...84046205 - 100 commits from branch
gitlab-org:master
- d03934ad - Organize package models by package type
- f6ccca19 - Apply suggestion to changelogs/unreleased/sk-organize-package-models.yml
- ff9e43c7 - Add table_name_prefix instead of table_name
- b31bb8f1 - Move DependencyLinkMetadatum to Nuget module
Toggle commit list-
3bc81d1a...84046205 - 100 commits from branch
enabled an automatic merge when the pipeline for b31bb8f1 succeeds
That was super fast @ksashikumar! Thank you so much
! I've enabled MWPS (Merge When Pipeline Succeeds), so it should be merged soon .This change will be deployed to GitLab.com next week, any other question please let me know :)
I'm assigning myself so I can ensure it's merged.
Edited by Mayra Cabreraassigned to @mayra-cabrera
mentioned in commit 8dab002e
added workflowstaging label and removed workflowin review label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
This merge request has been deployed to the pre.gitlab.com environment, and will be included in the upcoming self-managed GitLab 13.0.0 release.
This comment is generated automatically using the Release Tools project.added published label
mentioned in merge request gitlab-com/www-gitlab-com!49950 (closed)
added Enterprise Edition label