Skip to content

Correct roles for AlertManagement tasks

Sarah Yasonik requested to merge sy-alert-mangagement-permissions into master

What does this MR do?

This MR does these things:

  • Gates the <project>/-/alert_management endpoint to developer+
  • Groups the read_alert_management & read_alert_mangagement_alerts actions into read_alert_management_alert (because there isn't a different use-case for each, and the new name aligns better with the existing naming convention)
  • Renames update_alert_management_alerts to update_alert_management_alert for better consistency with action naming conventions
  • Moves read_alert_management_alert & update_alert_management_alert to :developer, per expected permissions for these features

A changelog is unneeded because this work is still behind a feature flag.

Related issue: #216053 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Rémy Coutable

Merge request reports