Skip to content

Enable telemetry reviews for snowplow events

What does this MR do?

Add more files to telemetry Dangerbot review recommendation

Besides tracking.rb and tracking.js, I would say we should also add related spec files and tracking_helper.rb and tracking_helper_spec.rb

cc @jeromezng @a_akgun

  'lib/gitlab/tracking.rb',
  'spec/lib/gitlab/tracking_spec.rb',
  'app/helpers/tracking_helper.rb',
  'spec/helpers/tracking_helper_spec.rb',
  'app/assets/javascripts/tracking.js',
  'spec/frontend/tracking_spec.js'

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #209742 (closed)

Edited by Rémy Coutable

Merge request reports