Dark theme for the Web IDE right sidebar
What does this MR do?
Adds support for dark theme for the Web IDE right sidebar (pipelines, live preview and web terminal).
Pipeline status icons currently have a white background, but I've opened gitlab-svgs!560 (merged) to allow its customization.
Issue: #213826 (closed)
Screenshots
Area | Before | After |
---|---|---|
Pipelines empty state | ![]() |
![]() |
Pipelines tab | ![]() |
![]() |
Pipeline logs | ![]() |
![]() |
Live preview tab | ![]() |
![]() |
Web Terminal empty state | ![]() |
![]() |
Web Terminal tab | ![]() |
![]() |
All changes committed | ![]() |
![]() |
Sidebar drag handle hover state | ![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %13.0
assigned to @himkp
mentioned in issue create-stage#12628 (closed)
added 412 commits
-
d58353db...bc55b37b - 411 commits from branch
master
- cc1b7d75 - Dark theme for the right sidebar
-
d58353db...bc55b37b - 411 commits from branch
1 Warning You’ve made some app changes, but didn’t add any tests.
That’s OK as long as you’re refactoring existing code,
but please consider adding any of the ~”backstage”, ~”documentation”, ~”QA” labels.1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 30587 "Dark theme for the Web IDE right sidebar"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 30587 "Dark theme for the Web IDE right sidebar"
If this merge request doesn’t need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer frontend Olena HK. ( @ohoral
)Kushal Pandya ( @kushalpandya
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Himanshu Kapoor
@mvanremmerden This is still WIP because the terminal styling isn't complete, but could you please verify the panels? We can perhaps set up a short call for styling the web terminal some time on Monday.
added 171 commits
-
c1b965ac...e25b7b91 - 170 commits from branch
master
- 2176801c - Dark theme for the right sidebar
-
c1b965ac...e25b7b91 - 170 commits from branch
added 5 commits
-
45516adc...1035dddc - 4 commits from branch
master
- 83f8f9df - Dark theme for the right sidebar
-
45516adc...1035dddc - 4 commits from branch
- Resolved by Phil Hughes
- Resolved by Phil Hughes
@tomquirk Since you reviewed !30477 (merged), could you please review this as well? Thanks :)
assigned to @tomquirk
added 96 commits
-
fc8c3a73...5d191707 - 95 commits from branch
master
- 15d112b8 - Dark theme for the right sidebar
-
fc8c3a73...5d191707 - 95 commits from branch
- Resolved by Tom Quirk
- Resolved by Tom Quirk
- Resolved by Tom Quirk
- Resolved by Himanshu Kapoor
@himkp loving these changes! Looks mostly good to me; I have left a few minor questions. Back to you
unassigned @tomquirk
assigned to @mvanremmerden
added 126 commits
-
15d112b8...972c347a - 125 commits from branch
master
- 118af2ea - Dark theme for the right sidebar
-
15d112b8...972c347a - 125 commits from branch
assigned to @tomquirk
@himkp Looks awesome, couldn't find any more issues than the one you fixed in our sync call, thanks a lot for taking care of this!
unassigned @mvanremmerden
unassigned @tomquirk
mentioned in issue gitlab-com/www-gitlab-com#6445 (closed)
@iamphill Since you reviewed other related MRs about dark mode, could you please review this as well? Thanks!
assigned to @iamphill
enabled an automatic merge when the pipeline for 80c801dd succeeds
mentioned in commit 7ff98341
mentioned in issue #30140 (closed)
added workflowstaging label and removed workflowin dev label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label