Skip to content

Dark theme for the Web IDE right sidebar

Himanshu Kapoor requested to merge 213826-dark-theme-right-sidebar into master

What does this MR do?

Adds support for dark theme for the Web IDE right sidebar (pipelines, live preview and web terminal).

Pipeline status icons currently have a white background, but I've opened gitlab-svgs!560 (merged) to allow its customization.

Issue: #213826 (closed)

Screenshots

Area Before After
Pipelines empty state Screenshot_2020-05-01_at_7.50.28_AM Screenshot_2020-05-01_at_7.55.39_AM
Pipelines tab Screenshot_2020-05-01_at_7.51.17_AM Screenshot_2020-05-01_at_7.54.19_AM
Pipeline logs Screenshot_2020-05-05_at_5.03.40_PM Screenshot_2020-05-05_at_5.00.51_PM
Live preview tab Screenshot_2020-05-01_at_7.51.41_AM Screenshot_2020-05-01_at_7.54.01_AM
Web Terminal empty state Screenshot_2020-05-01_at_7.51.49_AM Screenshot_2020-05-01_at_6.59.37_PM
Web Terminal tab Screenshot_2020-05-01_at_6.53.15_PM Screenshot_2020-05-05_at_1.05.16_PM
All changes committed Screenshot_2020-05-01_at_7.50.51_AM Screenshot_2020-05-01_at_7.55.53_AM
Sidebar drag handle hover state Screenshot_2020-05-01_at_3.33.13_PM Screenshot_2020-05-01_at_3.31.41_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Himanshu Kapoor

Merge request reports