Skip to content
Snippets Groups Projects

Dark theme for the Web IDE right sidebar

Merged Himanshu Kapoor requested to merge 213826-dark-theme-right-sidebar into master
All threads resolved!

What does this MR do?

Adds support for dark theme for the Web IDE right sidebar (pipelines, live preview and web terminal).

Pipeline status icons currently have a white background, but I've opened gitlab-svgs!560 (merged) to allow its customization.

Issue: #213826 (closed)

Screenshots

Area Before After
Pipelines empty state Screenshot_2020-05-01_at_7.50.28_AM Screenshot_2020-05-01_at_7.55.39_AM
Pipelines tab Screenshot_2020-05-01_at_7.51.17_AM Screenshot_2020-05-01_at_7.54.19_AM
Pipeline logs Screenshot_2020-05-05_at_5.03.40_PM Screenshot_2020-05-05_at_5.00.51_PM
Live preview tab Screenshot_2020-05-01_at_7.51.41_AM Screenshot_2020-05-01_at_7.54.01_AM
Web Terminal empty state Screenshot_2020-05-01_at_7.51.49_AM Screenshot_2020-05-01_at_6.59.37_PM
Web Terminal tab Screenshot_2020-05-01_at_6.53.15_PM Screenshot_2020-05-05_at_1.05.16_PM
All changes committed Screenshot_2020-05-01_at_7.50.51_AM Screenshot_2020-05-01_at_7.55.53_AM
Sidebar drag handle hover state Screenshot_2020-05-01_at_3.33.13_PM Screenshot_2020-05-01_at_3.31.41_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Himanshu Kapoor

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Himanshu Kapoor changed the description

    changed the description

  • Himanshu Kapoor
  • Author Maintainer

    @tomquirk Since you reviewed !30477 (merged), could you please review this as well? Thanks :)

  • added 1 commit

    • fc8c3a73 - Dark theme for the right sidebar

    Compare with previous version

  • Author Maintainer

    Rebased with master due to conflict.

  • Himanshu Kapoor added 96 commits

    added 96 commits

    Compare with previous version

  • Tom Quirk
  • Tom Quirk
  • Tom Quirk
  • unassigned @tomquirk

  • Himanshu Kapoor added 126 commits

    added 126 commits

    Compare with previous version

  • Himanshu Kapoor changed the description

    changed the description

  • Himanshu Kapoor changed the description

    changed the description

  • added 1 commit

    • d5c7696c - Dark theme for the right sidebar

    Compare with previous version

  • Author Maintainer

    Updated the MR to address the pipeline logs sidebar panel which was missed out earlier.

    Area Before After
    Pipeline logs Screenshot_2020-05-05_at_5.03.40_PM Screenshot_2020-05-05_at_5.00.51_PM
  • @himkp Looks awesome, couldn't find any more issues than the one you fixed in our sync call, thanks a lot for taking care of this! :slight_smile:

  • Marcel van Remmerden approved this merge request

    approved this merge request

  • Tom Quirk approved this merge request

    approved this merge request

  • unassigned @tomquirk

  • Author Maintainer

    @iamphill Since you reviewed other related MRs about dark mode, could you please review this as well? Thanks!

  • Phil Hughes resolved all threads

    resolved all threads

  • Phil Hughes approved this merge request

    approved this merge request

  • Phil Hughes enabled an automatic merge when the pipeline for 80c801dd succeeds

    enabled an automatic merge when the pipeline for 80c801dd succeeds

  • merged

  • Phil Hughes mentioned in commit 7ff98341

    mentioned in commit 7ff98341

  • mentioned in issue #30140 (closed)

  • added workflowstaging label and removed workflowin dev label

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Please register or sign in to reply
    Loading