Skip to content

Refactor ci minutes progress bar - pt2

Fabio Pitino requested to merge refactor-ci-minutes-progress-bar-2 into master

What does this MR do?

Related to #213964 (closed)

This is the 2nd part of the refactoring continued from !30276 (merged)

In this MR we are using the ci_minutes_progress_bar helper for extra minutes introduced in !30276 (merged).

We are also tidying up the code by removing entirely the logic in the helpers in favor of using Ci::Minutes::Quota for calculations. The helpers are now a very simple presentation layer, as they should be.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Grzegorz Bizon

Merge request reports