Skip to content

Refactor ci minutes progress bar

Fabio Pitino requested to merge refactor-ci-minutes-progress-bar into master

What does this MR do?

Related to #213964 (closed)

This MR is based on top of !29230 (merged) refactoring.

The NamespacesHelper has a lot of domain logic on how to calculate and display CI minutes. Given that now we have Ci::Minutes::Quota we can use this domain object in the view and pass in data to the helpers in order to render it properly.

In this MR we are converting the progress bar that displays minutes usage into a simpler helper that only knows how to format the data for the view (no business logic). For now we are only converting the progress bar for monthly minutes. In a follow up MR !30467 (merged) we are also converting the extra/purchased minutes progress bar and do the final cleanup.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Grzegorz Bizon

Merge request reports