Fix Service Templates missing Active toggle
What does this MR do?
Issue #215041 (closed)
MR !27778 (merged) introduced a regression in Admin > Service Templates which caused the active to not show. This is because ST were not initialized with the JS used in project services. This MR adds the missing file.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
added frontend groupecosystem [DEPRECATED] typebug labels
1 Warning You’ve made some app changes, but didn’t add any tests.
That’s OK as long as you’re refactoring existing code,
but please consider adding any of the ~backstage, documentation, QA labels.Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer frontend Miguel Rincon ( @mrincon
)Mike Greiling ( @mikegreiling
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖assigned to @justin_ho
changed milestone to %13.0
added devopscreate label
- Resolved by Mike Greiling
@rspeicher @leipert Do we need to wait for one release (%13.0) to fix a bug introduced in %12.10?
I'm not sure if we can use ~"Pick into 12.10" to be included in one of the next patch releases being created. What do you think?
assigned to @mrincon and unassigned @justin_ho
- Resolved by Justin Ho Tuan Duong
added severity2 label
assigned to @mikegreiling and unassigned @mrincon
- Resolved by Mike Greiling
@justin_ho Do we need a changelog entry here?