Cleanup Legacy Geo Errors
What does this MR do?
This is a split off from !29800 (merged) This is work towards this effort #211953 (closed)
Important Notes
In this MR I found a section of code related to NodeDetailsErrors that was never set to true. It appears that the error logic actually got pulled into a higher component GeoNodeDetails.
When working on the above mentioned MR I came across the data property isNodeDetailsFailed found in this file: https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/app/assets/javascripts/geo_nodes/components/geo_node_item.vue
After following it I realized there isn't any logic to set it to true, so it was never being used yet there was a lot of conditional logic using it.
The errors actually are being showcased here now: https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/app/assets/javascripts/geo_nodes/components/geo_node_details.vue#L93-100
Screenshots
Errors still working:
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team