Geo Nodes - Legacy Code Clean-Up
This MR is focused on some ~"technical debt" I have noticed in the javacripts/geo_nodes
directory. Most of this code was written > 2 years ago and could use a run through to clean up certain things.
However, with the coming re-designs for Geo, it makes sense to wait to do some of this but rather track it, so once we are in the code base, we can begin to tackle them as we go.
Living list of items
-
Rewrite existing
jest
tests usingvue-test-utils
- Test render instead of function return here
- Replace all
js-*
anddata-testid="*"
withref="*"
-
Rewrite any leftover
karma
tests injest
-
Clean up un-used props
-
Rewrite store in
vuex
-
Remove
eventBus
-
Replace
service
file -
Optimize components, example
-
Remove GeoNodesList component (Un-used)
cc: @fzimmer this is mainly for my sanity, I think a lot of this will happen naturally as we re-design Geo.
Edited by Zack Cuddy