Add feature flag for merge_ref_head
What does this MR do?
Add feature flag support on the frontend for diff_compare_with_head
Related to #27008 (closed)
Screenshots
n/a
Does this MR meet the acceptance criteria?
Conformity
Merge request reports
Activity
changed milestone to %12.10
mentioned in merge request !29713 (merged)
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer frontend Nick Kipling ( @nkipling
)Andrew Fontaine ( @afontaine
)backend Mario de la Ossa ( @mdelaossa
)Igor Drozdov ( @igor.drozdov
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Mark Florian
@jboyson please add the flag to the docs too. It's no big deal: please copy what we did it in !29577 (diffs)
added 27 commits
-
efbfce92...d549c1e2 - 26 commits from branch
master
- 07930fbc - Add feature flag for merge_ref_head
-
efbfce92...d549c1e2 - 26 commits from branch
- Resolved by Justin Boyson
@shampton could I get one of your quality reviews for this MR?
unassigned @shampton
- Resolved by Justin Boyson
- Resolved by Justin Boyson
unassigned @marcia
added Technical Writing docsfeature labels
added documentation label
mentioned in merge request gitlab-com/www-gitlab-com!34640 (merged)
added 1 commit
- c89cfbb0 - Apply suggestion to doc/user/project/merge_requests/versions.md
@markrian review-a-roo please
assigned to @markrian
- Resolved by Mark Florian
Thanks @jboyson! Just one question. Back to you
unassigned @markrian
@jboyson, also, can you squash your commits to fix
danger-review
?Otherwise, I'm happy to squash-on-merge.
changed milestone to %13.0
added missed-deliverable missed:12.10 labels
@markrian thanks for the review! I have added the test as requested and squashed my commits to one beautiful commit.
Back to you
assigned to @markrian
added 567 commits
-
94c3168e...10f18ece - 566 commits from branch
master
- 7b0a73e7 - Add feature flag for merge_ref_head
-
94c3168e...10f18ece - 566 commits from branch
Thanks @jboyson! LGTM
mentioned in commit 6fbe7503
mentioned in issue #27008 (closed)
picked the changes into the branch
12-10-stable-ee-patch-1
with commit 79c1bdcdAutomatically picked into !30213 (merged), will merge into
12-10-stable-ee
ready for12.10.1-ee
.mentioned in commit 79c1bdcd
mentioned in merge request !30213 (merged)
This merge request has been deployed to the pre.gitlab.com environment, and will be included in the upcoming self-managed GitLab 12.10.1 release.
This comment is generated automatically using the Release Tools project.added published label
added workflowcanary label
added workflowproduction label and removed workflowcanary label
added typemaintenance label