Skip to content

Support PAT authentication for visual reviews

Erick Bajao requested to merge eb-visual-review-tools-pat into master

What does this MR do?

Due to security implications brought up on !27804 (comment 316217435), we decided to use Personal Access Token authentication for now to make Visual Reviews work on private/internal projects.

This also has the added benefit of giving public projects the option to require authentication thus tying up the feedback to an existing GitLab account.

Related discussion: #42750 (comment 319279512) Related MR on visual-review-tools: visual-review-tools!25 (merged)

This also updates the visual-review-tools to 1.6.1.

Solves #42750 (closed)

Screenshots

Screen_Shot_2020-04-08_at_9.28.10_PM

Screen_Shot_2020-04-08_at_9.28.37_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jackie Porter

Merge request reports