Skip to content
GitLab
Next
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 55.4k
    • Issues 55.4k
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1.6k
    • Merge requests 1.6k
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
    • Model experiments
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLabGitLab
  • Issues
  • #42750
Closed
Open
Issue created Dec 12, 2019 by Tom Forbes@tom6

Visual reviews do not work with private and internal projects

Summary

With a private and internal projects in our private Gitlab instance visual reviews do not function correctly. Without the anonymous visual review flag set the endpoint to send anonymous feedback returns {"message":"403 Forbidden - Anonymous visual review feedback is disabled"}, as expected.

When we enable this flag, the endpoint returns a 404 error code. All the configuration is set correctly.

Steps to reproduce

  1. Create a private or internal project on a private Gitlab instance
  2. Enable the anonymous visual review feature flag
  3. Try and add anonymous feedback
  4. See that it does not work

What is the expected correct behavior?

We should be able to add feedback to private and internal projects.

Proposal

Add a new require-authentication='true' data parameter to the script tag. This will re-enable the visual reviews for private/internal projects and users will add their PAT to leave feedback.

This will also enable public project maintainers to require a PAT for visual review feedback on their projects if they so desire.

Edited Apr 07, 2020 by James Heimbuck
Assignee
Assign to
Time tracking