Skip to content

Visual reviews do not work with private and internal projects

Summary

With a private and internal projects in our private Gitlab instance visual reviews do not function correctly. Without the anonymous visual review flag set the endpoint to send anonymous feedback returns {"message":"403 Forbidden - Anonymous visual review feedback is disabled"}, as expected.

When we enable this flag, the endpoint returns a 404 error code. All the configuration is set correctly.

Steps to reproduce

  1. Create a private or internal project on a private Gitlab instance
  2. Enable the anonymous visual review feature flag
  3. Try and add anonymous feedback
  4. See that it does not work

What is the expected correct behavior?

We should be able to add feedback to private and internal projects.

Proposal

Add a new require-authentication='true' data parameter to the script tag. This will re-enable the visual reviews for private/internal projects and users will add their PAT to leave feedback.

This will also enable public project maintainers to require a PAT for visual review feedback on their projects if they so desire.

Edited by James Heimbuck