Skip to content

Fix tillerless helm command permissions

Hordur Freyr Yngvason requested to merge fix-tillerless-helm-commands into master

What does this MR do?

Helm commands run in the context of a service account, currently tiller, but when a cluster is tillerless from the start they do not have this account present.

Previously, they were being created as part of the helm tiller installation.

This is meant to unblock the tillerless migration, see #209736 (comment 320695843)

This fixes a bug that is guarded by a feature flag, and the side effect of two extra network calls to check if these two resources exist should be invisible to other users.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports