Move SameFilesystemError into service
What does this MR do?
Moves the same filesystem check from the job into the service. This has a couple of advantages:
- I believe sidekiq will retry because the error is unhandled, even though a retry will never work.
- The service handles and logs errors correctly.
- We need unified error handling to allow us to expose the status to admins #210041 (closed)
SameFilesystemError
was originally introduced in !28469 (merged)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team